For me it depends on one thing - will I ever have to enter the password on a phone or tablet (99% chance no).
If no, long, complex, all chars, random
If yes, short (which I think of as 12-16 chars), alphanum, no ambiguous chars (l and 1 for example), random